Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Flask to FastAPI #64

Merged
merged 9 commits into from
Jan 1, 2025
Merged

Conversation

joemoorhouse
Copy link
Collaborator

This PR migrates from Flask to FastAPI. Mainly this is done to:

  • Take advantage of FastAPI's excellent documentation generation, especially by:
  • Making use of the Pydantic API classes defined in physrisk.

joemoorhouse and others added 7 commits December 29, 2024 17:14
Signed-off-by: Joe Moorhouse <[email protected]>
Signed-off-by: Joe Moorhouse <[email protected]>
Signed-off-by: Joe Moorhouse <[email protected]>
Signed-off-by: Joe Moorhouse <[email protected]>
Signed-off-by: Joe Moorhouse <[email protected]>
Signed-off-by: Joe Moorhouse <[email protected]>
Signed-off-by: Joe Moorhouse <[email protected]>
@joemoorhouse
Copy link
Collaborator Author

Hi @xbarra, @NickKellett, (Happy New Year) FYI, this PR moves physrisk-api from Flask to FastAPI. A test deployment is on cluster 2 and we now have Open API:
https://physrisk-api-test-physrisk.apps.odh-cl2.apps.os-climate.org/docs
A bit more documentation work to do, but hard part done. I'll merge this PR imminently unless any reason to hold off.
Thanks,
Joe

@NickKellett
Copy link

That's brilliant Joe - well done (and Happy New Year!)

@joemoorhouse joemoorhouse merged commit 2ccff39 into os-climate:main Jan 1, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants